notes-vci-token #112
notes-vci-token #112
Conversation
src/main/java/es/in2/issuer/backend/shared/domain/model/entities/CredentialIssuanceRecord.java
Outdated
Show resolved
Hide resolved
| Issuer issuer(); | ||
| String validFrom(); | ||
| String validUntil(); | ||
| CredentialStatusObject credentialStatus(); |
There was a problem hiding this comment.
Per què utilitzem "object"?
There was a problem hiding this comment.
Perquè ja existeix el CredentialStatus que és un enum que conté Withdrawn, Draft, Issued...
There was a problem hiding this comment.
Canviar per CredentialLifecycleStatus
src/main/java/es/in2/issuer/backend/oidc4vci/domain/service/impl/TokenWorkflowImpl.java
Show resolved
Hide resolved
src/main/java/es/in2/issuer/backend/oidc4vci/domain/service/impl/TokenWorkflowImpl.java
Show resolved
Hide resolved
| return jwtService.generateJWT(payload.toString()); | ||
| } | ||
|
|
||
| private Mono<Void> ensureGrantTypeIsPreAuthorizedCodeAndTxCodeAreCorrect(String grantType, String preAuthorizedCode, String txCode) { |
There was a problem hiding this comment.
creus que es pot separar la reponsabilitat de ensureGrantTypeIsPreAuthorizedCodeAndTxCodeAreCorrect()? Per un costat el grant_type i per altre el pre-authorized_code y el tx_code?
There was a problem hiding this comment.
Abans ho teníem per separat (a main està així) i em vas demanar que ho unís en una sola funció.
There was a problem hiding this comment.
Separar-ho
| } | ||
|
|
||
| @Override | ||
| public Mono<Void> setJtis(String id, String accessTokenJti, String refreshTokenJti) { |
There was a problem hiding this comment.
Quan fas el set del JTI no has hagut de buscar abans el preAuthorizedCode i obtens el CredentialIssuanceRecord?
There was a problem hiding this comment.
No, perquè el PreAuthorizedCode el rebo amb el body de la request del TokenController.
There was a problem hiding this comment.
Demanar directament l'objecte
...va/es/in2/issuer/backend/shared/domain/service/impl/CredentialIssuanceRecordServiceImpl.java
Outdated
Show resolved
Hide resolved
| JsonNode credential = objectMapper.readTree(credentialProcedure.getCredentialDecoded()); | ||
| return switch (credentialProcedure.getCredentialType()) { | ||
| JsonNode credential = objectMapper.readTree(credentialJson); | ||
| return switch (credentialType) { |
There was a problem hiding this comment.
S'hauria de revisar perque el credentialEmployee ja no té signer i l'Issuer deixarà de tenir-lo. Per què s'utilitza aquesta funció?
There was a problem hiding this comment.
S'utilitza en el handleOperationMode del CredentialIssuanceWorkflow, per enviar un mail en el cas d'ASYNC i al handlePostRecoverError del CredentialSignerWorkflow quan no s'ha pogut firmar.
There was a problem hiding this comment.
Revisar quan Rubén ho tingui corregit (getEmail)
No description provided.